Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(onboarding): fix condition to enable SSI telemetry #11101

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Oct 21, 2024

We noticed we weren't getting any telemetry

https://datadoghq.atlassian.net/browse/INPLAT-11

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@iamluc iamluc requested a review from a team as a code owner October 21, 2024 12:03
@iamluc iamluc requested a review from emmettbutler October 21, 2024 12:03
Copy link
Contributor

CODEOWNERS have been resolved as:

lib-injection/sources/sitecustomize.py                                  @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Oct 21, 2024

Benchmarks

Benchmark execution time: 2024-10-21 12:42:34

Comparing candidate commit a490f5a in PR branch luc/fix-ssi-telemetry-not-enabled with baseline commit b6c85b1 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 365 metrics, 53 unstable metrics.

@emmettbutler emmettbutler changed the title [SSI/Onboarding] Fix condition to enable SSI telemetry chore(onboarding): fix condition to enable SSI telemetry Oct 21, 2024
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 21, 2024
@iamluc iamluc merged commit 7e8a914 into main Oct 22, 2024
569 of 575 checks passed
@iamluc iamluc deleted the luc/fix-ssi-telemetry-not-enabled branch October 22, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants