Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dbapi): add iterable methods to object proxy (backport #4205) #4281

Merged
merged 4 commits into from
Oct 6, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 5, 2022

This is an automatic backport of pull request #4205 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

According to the [dbapi spec](https://peps.python.org/pep-0249/#iter)
cursors can be iterable. For some reason wrapt.ObjectProxy does not
proxy the `__iter__` or `__next__` methods. The solution is to simply
add them to the base TraceCursor class which is used in our dbapi
integrations.

(cherry picked from commit 7bbef52)
@mergify mergify bot requested a review from a team as a code owner October 5, 2022 14:24
@mabdinur
Copy link
Contributor

mabdinur commented Oct 5, 2022

Blocks: #4250

@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 5, 2022
@mergify mergify bot merged commit 2947d5b into 1.5 Oct 6, 2022
@mergify mergify bot deleted the mergify/bp/1.5/pr-4205 branch October 6, 2022 17:33
@github-actions github-actions bot added this to the v1.5.1 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants