-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dbm): add peer entity dbm comment attributes #8286
Conversation
62f8dd2
to
f21d056
Compare
BenchmarksBenchmark execution time: 2024-02-26 13:17:11 Comparing candidate commit e9e86ec in PR branch Found 3 performance improvements and 3 performance regressions! Performance is the same for 197 metrics, 9 unstable metrics. scenario:flasksimple-appsec-get
scenario:flasksimple-appsec-telemetry
scenario:otelspan-start
scenario:samplingrules-average_match
scenario:samplingrules-high_match
scenario:span-add-metrics
|
Datadog ReportBranch report: ✅ 0 Failed, 27323 Passed, 33044 Skipped, 6h 48m 31.45s Total duration (1h 56m 42.81s time saved) |
Adds the following 2 new attributes to the DBM injected query comments:
ddh
: represents the peer hostname of the request.dddb
: represents the db instance.These tags are necessary so the APM<->DBM connection still works when using the
peer.service
powered features.Integrations affected:
psycopg
psycopg2
The following integrations support DBM comment injection but do not set tags with information about the db name or peer hostname, so the comment attributes won't be added:
dbapi
dbapi_async
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.@DataDog/security-design-and-guidance
.Reviewer Checklist