Add perf telemetry collection #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
hmahmood
reviewed
Dec 5, 2023
| if val <= oldVal { | ||
| return | ||
| } | ||
| if a.CompareAndSwap(oldVal, val) { |
There was a problem hiding this comment.
Would we ever return false here?
There was a problem hiding this comment.
Yes, the point is that if another goroutine managed to update the value underneath, you don't make a change.
There was a problem hiding this comment.
It shouldn't be possible based on the structure of other code, but this is the safe way to do it.
There was a problem hiding this comment.
So we would try again in that case?
There was a problem hiding this comment.
Yes, it would do the load, max check, and CAS again.
hmahmood
approved these changes
Dec 5, 2023
usamasaqib
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds optional collection of perf (perf buffer and ring buffer) telemetry
Motivation
Simplifies consumption of the telemetry values from the users of ebpf-manager.
Additional Notes
Describe how to test your changes