This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
Improve signal handling for df timeout
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case <-time.After(2 * time.Second): | ||
| // Kill the process if it takes too long | ||
| if killErr := cmd.Process.Kill(); killErr != nil { | ||
| log.Fatal("failed to kill:", killErr) |
There was a problem hiding this comment.
Why do we have to kill the whole process anymore ? Can't we just return the error ?
There was a problem hiding this comment.
I thought it made sense to ensure that multiple df calls spawned by gohai weren't running at the same time. The change was prompted by a case where df was taking long and successive gohai calls kept spawning new, time-intensive processes. This will kill df before it returns, and not interrupt the main gohai process
There was a problem hiding this comment.
Ah yeah misread the code. looks good to me!
talwai
added a commit
that referenced
this pull request
Aug 31, 2015
Improve signal handling for `df` timeout
This was referenced Aug 31, 2015
hush-hush
pushed a commit
that referenced
this pull request
Apr 13, 2023
Improve signal handling for `df` timeout
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #14 actually didn't work as expected, exiting with the following in the event of timeouts:
This PR should fix the deadlock issue, by properly handling the signals in
select. It also propagates the error message todd-agentand adds a test for the timeout.