Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling (Agetn --> Agent) #1127

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Correct spelling (Agetn --> Agent) #1127

merged 7 commits into from
Jul 28, 2023

Conversation

jexonyx
Copy link
Contributor

@jexonyx jexonyx commented Jul 26, 2023

What this PR does / why we need it:
Trivial spelling corrections

Checklist

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@jexonyx jexonyx requested a review from a team as a code owner July 26, 2023 01:14
Copy link
Contributor

@celenechang celenechang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please bump the last digit of the chart version. It is mandatory to trigger a new chart release

@clamoriniere
Copy link
Collaborator

Hi @jexonyx

Thanks for update the chart version, and sorry I wasn't clear enough about the "chart version bump process". But after update the version you need to run the script that will take the new version and update the README.md

see the list of action in the Pull request template description: https://github.com/DataDog/helm-charts/blob/main/.github/PULL_REQUEST_TEMPLATE.md#checklist

@clamoriniere clamoriniere merged commit 8b9a6ae into DataDog:main Jul 28, 2023
14 of 21 checks passed
@jexonyx jexonyx deleted the typos branch July 29, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants