Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include volume in daemonset-volumes-windows definition #1134

Merged
merged 3 commits into from
Jul 28, 2023
Merged

include volume in daemonset-volumes-windows definition #1134

merged 3 commits into from
Jul 28, 2023

Conversation

anders-ni
Copy link
Contributor

@anders-ni anders-ni commented Jul 27, 2023 •
edited
Loading

What this PR does / why we need it:

The chart does not render the daemonset correctly for windows datadog agents due to missing the logdatadog volume

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@anders-ni anders-ni marked this pull request as ready for review July 27, 2023 17:43
@anders-ni anders-ni requested a review from a team as a code owner July 27, 2023 17:43
@clamoriniere clamoriniere added the chart/datadog This issue or pull request is related to the datadog chart label Jul 28, 2023
clamoriniere
clamoriniere approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anders-ni

thanks for finding and fixing this issue. 🙇

@clamoriniere clamoriniere enabled auto-merge (squash) July 28, 2023 09:20
@clamoriniere clamoriniere merged commit 6d23bee into DataDog:main Jul 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clamoriniere clamoriniere clamoriniere approved these changes

Assignees
No one assigned
Labels
chart/datadog This issue or pull request is related to the datadog chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

targetSystem: Windows- Chart does not render logdatadog volume in daemonset
2 participants
@anders-ni @clamoriniere