Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baseline tests for Agent chart #1209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Oct 18, 2023

What this PR does / why we need it:

Adding 'baseline' tests for datadog chart covering default cases.

Why?

  • Render chart with default settings to catch typos.
  • Include the resources diff in the PR when baseline changes.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@levan-m levan-m requested a review from a team as a code owner October 18, 2023 21:14
@levan-m levan-m changed the title Add baseline tests to Agent chart Add baseline tests for Agent chart Oct 18, 2023
@levan-m levan-m force-pushed the levan-m/agent-baseline-test branch 2 times, most recently from c945a6e to 968d2eb Compare October 18, 2023 21:18
@levan-m levan-m requested a review from a team as a code owner October 18, 2023 21:18
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny edit

@@ -12,4 +12,4 @@
- [ ] Documentation has been updated with helm-docs (run: `.github/helm-docs.sh`)
- [ ] `CHANGELOG.md` has been updated
- [ ] Variables are documented in the `README.md`
- [ ] For Datadog Operator chart or value changes update the test baselines (run: `make update-test-baselines`)
- [ ] For `datadog-operator` or `datadog` chart or value changes update the test baselines (run: `make update-test-baselines`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] For `datadog-operator` or `datadog` chart or value changes update the test baselines (run: `make update-test-baselines`)
- [ ] For `datadog-operator` or `datadog` chart or value changes, update the test baselines (run: `make update-test-baselines`)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants