imp: add talos.dev compatibility #1572
Open
+27
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charts/datadog/templates/_container-host-release-volumemounts.yaml
Outdated
Show resolved
Hide resolved
brycekahle
reviewed
Oct 31, 2024
| @@ -65,7 +65,7 @@ | |||
| mountPropagation: {{ .Values.datadog.hostVolumeMountPropagation }} | |||
| readOnly: true | |||
| {{- include "linux-container-host-release-volumemounts" . | nindent 4 }} | |||
| {{- if .Values.datadog.systemProbe.enableDefaultOsReleasePaths }} | |||
| {{- if or .Values.datadog.systemProbe.enableDefaultOsReleasePaths (not .Values.datadog.disableDefaultOsReleasePaths) }} | |||
There was a problem hiding this comment.
I think this might need to be and, otherwise the default value of true for the deprecated datadog.systemProbe.enableDefaultOsReleasePaths will always ignore the new config option.
brycekahle
reviewed
Oct 31, 2024
| - hostPath: | ||
| path: {{ .Values.datadog.systemProbe.osReleasePath | default .Values.datadog.osReleasePath }} | ||
| name: os-release-file | ||
| {{- end }} | ||
| {{- if or (and (eq (include "should-enable-system-probe" .) "true") .Values.datadog.systemProbe.enableDefaultOsReleasePaths) .Values.datadog.sbom.host.enabled }} | ||
| {{- if or (and (eq (include "should-enable-system-probe" .) "true") (or .Values.datadog.systemProbe.enableDefaultOsReleasePaths (not .Values.datadog.disableDefaultOsReleasePaths))) .Values.datadog.sbom.host.enabled }} |
There was a problem hiding this comment.
as above, I think this should be and
…s in favor of .Values.datadog.disableDefaultOsReleasePaths
|
@brycekahle @clamoriniere I think I made a mistake as I didn't want to close the PR. @brycekahle I applied your fix :) |
brycekahle
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
Fix processAgent crash when Running on talos.dev cluster. It's because it try to mount files which don't exist on the OS.
Special notes for your reviewer:
I didn't managed to run
make update-test-baselinesChecklist
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mdmake update-test-baselines)