Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Orch] Add additional permissions for operator to view CRDs #1583

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

JLineaweaver
Copy link
Contributor

What this PR does / why we need it:

When using the Operator, we need additional permissions for CRDs. We need to allow the cluster agent to view these custom resources and in order to do that the operator needs permission to see them. This is currently disabled by default

Which issue this PR fixes

This fixes a current bug in the operator where users are unable to configure the orchestrator explorer to view and index custom resources

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

When using the Operator, we need additional permissions for CRDs. We
need to allow the cluster agent to view these custom resources and in
order to do that the operator needs permission to see them. This is
currently disabled by default
@JLineaweaver JLineaweaver requested a review from a team as a code owner October 23, 2024 19:53
@github-actions github-actions bot added the chart/datadog-operator This issue or pull request is related to the datadog-operator chart label Oct 23, 2024
@JLineaweaver
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 1, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 37m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit fd50dbe into main Nov 1, 2024
40 checks passed
@dd-mergequeue dd-mergequeue bot deleted the jlineaweaver/orch-crd-rbac branch November 1, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog-operator This issue or pull request is related to the datadog-operator chart mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants