Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datadog): version 3.84.3 was not created properly #1650

Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix(datadog): version 3.84.3 was not created properly #1650

merged 1 commit into from
Dec 24, 2024
+2 −2

Conversation

clamoriniere
Copy link
Collaborator

@clamoriniere clamoriniere commented Dec 23, 2024 •
edited
Loading

What this PR does / why we need it:

Properly create the datadog 3.84.3 chart version

Which issue this PR fixes

the chart version was not bumped properly in the chart.yaml file, but the changelog.md already mention it https://github.com/DataDog/helm-charts/blob/main/charts/datadog/CHANGELOG.md#3843
and it was part of the PR #1639

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@clamoriniere clamoriniere requested a review from a team as a code owner December 23, 2024 23:50
@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Dec 23, 2024
@clamoriniere
Copy link
Collaborator Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 24, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-24 08:46:35 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 37m.

2024-12-24 09:25:17 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 19de1bf into main Dec 24, 2024
27 checks passed
@dd-mergequeue dd-mergequeue bot deleted the clamoriniere/fix-datadog-3.84.3 branch December 24, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adel121 adel121 adel121 approved these changes

Assignees
No one assigned
Labels
chart/datadog This issue or pull request is related to the datadog chart mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clamoriniere @adel121