Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore spaces in assert message tests #11478

Merged
merged 9 commits into from
Feb 9, 2022
Merged

Ignore spaces in assert message tests #11478

merged 9 commits into from
Feb 9, 2022

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Feb 9, 2022 •
edited
Loading

What does this PR do?

Update the test to not check for whitespace in assertions

Motivation

Failing tests on master after #11303

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@sarah-witt sarah-witt marked this pull request as ready for review February 9, 2022 21:11
@sarah-witt sarah-witt requested review from a team as code owners February 9, 2022 21:11
@sarah-witt sarah-witt changed the title Update assert message formatting Ignore spaces in assert message tests Feb 9, 2022
@sarah-witt sarah-witt merged commit f33bb5a into master Feb 9, 2022
@sarah-witt sarah-witt deleted the sarah/test-base-assert branch February 9, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarah-witt @ofek