Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect more metrics by default #16631

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jan 16, 2024

What does this PR do?

Collect more metrics by default

Motivation

Feature request

Additional Notes

datadoghq.atlassian.net/browse/AI-3731

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@FlorentClarret
Copy link
Member Author

FlorentClarret commented Jan 16, 2024

Current dependencies on/for this PR:

This comment was autogenerated by Freephite.

@ghost ghost added the integration/tomcat label Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29669c4) 90.57% compared to head (169cc17) 90.56%.
Report is 4 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
tomcat 63.63% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Jan 16, 2024

Test Results

12 files  12 suites   57s ⏱️
 2 tests  2 ✅  0 💤 0 ❌
24 runs  12 ✅ 12 💤 0 ❌

Results for commit 169cc17.

♻️ This comment has been updated with latest results.

@FlorentClarret FlorentClarret force-pushed the florentclarret/tomcat/counter_metrics branch from cf3de47 to d00f631 Compare January 16, 2024 17:00
@FlorentClarret FlorentClarret force-pushed the florentclarret/tomcat/update_metrics branch from 3cba4b9 to 1371088 Compare January 16, 2024 17:00
Base automatically changed from florentclarret/tomcat/counter_metrics to master January 17, 2024 10:41
@FlorentClarret FlorentClarret force-pushed the florentclarret/tomcat/update_metrics branch 3 times, most recently from ba55a54 to 458323b Compare January 18, 2024 07:58
@FlorentClarret FlorentClarret force-pushed the florentclarret/tomcat/update_metrics branch from 458323b to 169cc17 Compare January 18, 2024 08:00
@FlorentClarret FlorentClarret marked this pull request as ready for review January 18, 2024 08:06
@FlorentClarret FlorentClarret requested a review from a team as a code owner January 18, 2024 08:06
@FlorentClarret FlorentClarret merged commit 3ef7e30 into master Jan 18, 2024
36 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/tomcat/update_metrics branch January 18, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants