Ensure that built wheels are reproducible part 1 #16772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ofek
force-pushed
the
ofek/reproducible
branch
from
a741da6
to
b6248df
Compare
alopezz
previously approved these changes
Feb 2, 2024
|
It doesn't appear to work for all dependencies. I'm looking at this file https://github.com/DataDog/integrations-core/pull/16771/files#diff-ba516e5e56ca6a483cc5890b2d8d1274d9f60ddc6cd5ea92ee0e7970a285f8b1 Dependencies that are now reproducible:
|
|
I'm going to merge for now and troubleshoot in a separate PR |
ofek
changed the title
Kyle-Neale
pushed a commit
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Noticed in https://github.com/DataDog/integrations-core/pull/16771/files
Additional Notes
It is unclear if this will work because as far as I know not only does setuptools not have reproducibility guarantees but neither do the patchers. I did find: