Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin black and update datamodel-code-generator #16776

Closed
wants to merge 2 commits into from

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Feb 2, 2024

What does this PR do?

Unpin black and update datamodel-code-generator

Motivation

#16712 (comment)

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@FlorentClarret FlorentClarret requested a review from a team as a code owner February 2, 2024 12:58
@ghost ghost added the dev_package label Feb 2, 2024
@FlorentClarret FlorentClarret force-pushed the florentclarret/ddev/datamodel branch from 8d7222b to 88561ec Compare February 2, 2024 12:59
Copy link

github-actions bot commented Feb 2, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2481e0) 90.53% compared to head (2f9364d) 90.72%.
Report is 13 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
active_directory 100.00% <ø> (+17.64%) ⬆️
activemq ?
aerospike 87.17% <ø> (+0.32%) ⬆️
amazon_msk 88.91% <ø> (ø)
arangodb 98.23% <ø> (ø)
argocd 87.81% <ø> (ø)
aspdotnet 100.00% <ø> (ø)
avi_vantage 91.35% <ø> (ø)
boundary 100.00% <ø> (ø)
calico 84.61% <ø> (ø)
cassandra ?
cert_manager 77.41% <ø> (ø)
cilium 77.72% <ø> (ø)
cockroachdb 91.52% <ø> (ø)
confluent_platform ?
coredns 94.61% <ø> (ø)
datadog_checks_dev 82.53% <ø> (+0.03%) ⬆️
dcgm 97.40% <ø> (ø)
dotnetclr 91.39% <ø> (+12.90%) ⬆️
envoy 95.27% <ø> (+0.29%) ⬆️
exchange_server 96.85% <ø> (+11.81%) ⬆️
fluxcd 88.31% <ø> (ø)
gitlab 91.95% <ø> (+1.00%) ⬆️
haproxy 95.13% <ø> (+0.16%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
iis 95.05% <ø> (ø)
impala 97.97% <ø> (ø)
istio 77.74% <ø> (+0.52%) ⬆️
jboss_wildfly ?
kafka ?
karpenter 94.36% <ø> (ø)
kong 87.62% <ø> (ø)
linkerd 85.22% <ø> (+1.13%) ⬆️
nvidia_triton 88.52% <ø> (ø)
openmetrics 98.08% <ø> (ø)
openstack_controller 93.77% <ø> (ø)
postgres 92.87% <ø> (+0.03%) ⬆️
presto ?
pulsar 100.00% <ø> (ø)
rabbitmq 95.67% <ø> (ø)
ray 96.45% <ø> (ø)
scylla 98.29% <ø> (ø)
solr ?
strimzi 89.70% <ø> (ø)
teamcity 88.74% <ø> (+3.21%) ⬆️
temporal 100.00% <ø> (ø)
torchserve 97.32% <ø> (ø)
vault 95.53% <ø> (+0.57%) ⬆️
weaviate 76.27% <ø> (ø)
weblogic ?
windows_performance_counters 98.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Feb 2, 2024

Test Results

  248 files    248 suites   1h 37m 9s ⏱️
1 791 tests 1 774 ✅    13 💤 0 ❌ 4 🔥
7 336 runs  5 542 ✅ 1 790 💤 0 ❌ 4 🔥

For more details on these errors, see this check.

Results for commit 2f9364d.

♻️ This comment has been updated with latest results.

@FlorentClarret FlorentClarret requested review from a team as code owners February 2, 2024 13:15
@FlorentClarret FlorentClarret marked this pull request as draft February 2, 2024 13:39
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is supposed to be a no-changelog change, right? Just some renames of internal modules

@dd-devflow dd-devflow bot deleted the florentclarret/ddev/datamodel branch August 4, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants