Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhere to code style #3325

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Adhere to code style #3325

merged 2 commits into from
Mar 19, 2019

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

Format style according to #3299

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@ChristineTChen ChristineTChen requested a review from a team as a code owner March 18, 2019 19:04
@ofek ofek changed the title Format style for cacti Adhere to code style Mar 19, 2019
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #3325 into master will decrease coverage by 4.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3325      +/-   ##
==========================================
- Coverage   85.59%   81.46%   -4.14%     
==========================================
  Files         696        4     -692     
  Lines       36366      178   -36188     
  Branches     4412       25    -4387     
==========================================
- Hits        31127      145   -30982     
+ Misses       3976       27    -3949     
+ Partials     1263        6    -1257

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #3325 into master will decrease coverage by 4.55%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3325      +/-   ##
==========================================
- Coverage   85.59%   81.03%   -4.56%     
==========================================
  Files         696        4     -692     
  Lines       36366      174   -36192     
  Branches     4412       25    -4387     
==========================================
- Hits        31127      141   -30986     
+ Misses       3976       27    -3949     
+ Partials     1263        6    -1257

@ofek ofek merged commit 9584fb4 into master Mar 19, 2019
@ofek ofek deleted the christine/format-cacti branch March 19, 2019 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants