Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consul 1.9.0 metrics #8095

Merged
merged 4 commits into from
Dec 3, 2020
Merged

Add consul 1.9.0 metrics #8095

merged 4 commits into from
Dec 3, 2020

Conversation

coignetp
Copy link
Contributor

What does this PR do?

hashicorp/raft#409 and hashicorp/consul#8271 are merged and released in Consul 1.9.0, we can now easily parse them.

I updated the README instructions for DogStatsD user to have the same tags as the prometheus metrics

Motivation

Additional Notes

Removed some consul environment

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes for docs team approval

Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Some suggestions / questions

consul/README.md Show resolved Hide resolved
consul/tests/common.py Show resolved Hide resolved
consul/tests/test_integration.py Outdated Show resolved Hide resolved
@coignetp coignetp merged commit 6207c30 into master Dec 3, 2020
@coignetp coignetp deleted the paul/consul-190 branch December 3, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants