Fix rmi socket connection timeout #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2020
prognant
force-pushed
the
prognant/fix-RMI-socket-connection-timeout
branch
from
4224e31 to
8bb067d
Compare
| @@ -27,6 +29,8 @@ | |||
| private static final String KEY_STORE_PASSWORD_KEY = "key_store_password"; | |||
| private static final String DEFAULT_RMI_RESPONSE_TIMEOUT = | |||
| "15000"; // Match the collection period default | |||
| // Match the default RMI connection timeout value | |||
| private static final Integer DEFAULT_RMI_CONNECTION_TIMEOUT = Integer.valueOf(0); | |||
There was a problem hiding this comment.
Hi @prognant, I'm not sure if we should put 0 here as the default since 0 means infinite and the purpose of this PR is to put a non-zero default value for the socket timeout..
There was a problem hiding this comment.
@HantingZhang2 I agree, I'm always a little bit concerned about changing a default value, in this cas we may use something like 15sec (as initially suggested) or 30sec it should not impact existing deployment.
truthbk
approved these changes
Mar 31, 2020
| rmiConnectionTimeout = (Integer) connectionParams.get("rmi_connection_timeout"); | ||
| } catch (final ClassCastException e) { | ||
| rmiConnectionTimeout = | ||
| Integer.parseInt((String) connectionParams.get("rmi_connection_timeout")); |
There was a problem hiding this comment.
note to self: this would not trigger a java.lang.NumberFormatException when connectionParams.get("rmi_connection_timeout") is null, because the cast of (Integer) null is valid. So we're good.
prognant
added a commit
that referenced
this pull request
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #283 & #282
It aims to provide piece of resolution for #279
It allows to set a RMI connection timeout on a per-instance basis, using the configuration parameter
rmi_connection_timeout(in milliseconds).