[jmx] if the exception is an IOException, throw it. Instance should be removed. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yannmh this is supposed to address the case when one of the instances goes down. If we don't handle the exception in the correct place we apparently enter a messy loop that potentiallys ends up having the jmxfetch stop reporting metrics for a rather large window of time ~15+ minutes if I remember correctly. |
| @@ -6,3 +6,6 @@ jdk: | |||
| notifications: | |||
| slack: | |||
| secure: bUPdpDtrBYvlJ93AmfqvPU6ZSZhFHZJiIoNf0bXJVNZyxp2rjfMC8BG6XkesbKk62s7NJM0yfZhhLAzjNG3tSA9iL5i3npbl8kRaUi2zEDOCEG0zZ+FX2NxTiNH937S6QRmCBHe9/KEkSRuMY3HNRUidAq8w6dVCrWxxj5NwxjU= | |||
|
|
|||
| addons: | |||
| hostname: dd-jmxfetch-testhost | |||
There was a problem hiding this comment.
|
Nice catch @truthbk ! It looks good, feel free to merge it. |
truthbk
added a commit
that referenced
this pull request
Mar 22, 2016
[jmx] if the exception is an IOException, throw it. Instance should be removed.
olivielpeau
added a commit
to DataDog/dd-agent
that referenced
this pull request
Mar 23, 2016
* [FEATURE] Allow configuration of StatsD host. See [#85][] * [IMPROVEMENT] Re-throw IOException caught at the instance-level to handle them properly. See [#83][] [#83]: DataDog/jmxfetch#83 [#85]: DataDog/jmxfetch#85
olivielpeau
added a commit
to DataDog/dd-agent
that referenced
this pull request
Mar 23, 2016
**Changes** * [FEATURE] Allow configuration of StatsD host. See [#85][] * [IMPROVEMENT] Re-throw IOException caught at the instance-level to handle them properly. See [#83][] [#83]: DataDog/jmxfetch#83 [#85]: DataDog/jmxfetch#85
olivielpeau
added a commit
to DataDog/dd-agent
that referenced
this pull request
Mar 30, 2016
**Changes** * [FEATURE] Allow configuration of StatsD host. See [#85][] * [IMPROVEMENT] Re-throw IOException caught at the instance-level to handle them properly. See [#83][] [#83]: DataDog/jmxfetch#83 [#85]: DataDog/jmxfetch#85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IOException should be handled here:
https://github.com/DataDog/jmxfetch/blob/master/src/main/java/org/datadog/jmxfetch/App.java#L204