Update clap to 4.5 (#1159)

### What does this PR do? This commit updates the clap crate in use by lading to the latest release.
DataDog · Dec 17, 2024 · a05abc7 · a05abc7
1 parent de93d16
commit a05abc7
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 74 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/lading/Cargo.toml b/lading/Cargo.toml
@@ -25,10 +25,11 @@ average = { version = "0.15", default-features = false, features = [] }
 bollard = { version = "0.18", default-features = false, features = ["pipe", "http"] }
 byte-unit = { workspace = true }
 bytes = { workspace = true, features = ["std"] }
-clap = { version = "3.2", default-features = false, features = [
+clap = { version = "4.5", default-features = false, features = [
   "std",
   "suggestions",
   "derive",
+  "help",
 ] }
 flate2 = { version = "1.0.34", default-features = false, features = [
   "rust_backend",

diff --git a/lading/src/bin/lading.rs b/lading/src/bin/lading.rs
@@ -130,17 +130,17 @@ impl FromStr for CliKeyValues {
 #[clap(group(
     ArgGroup::new("target")
         .required(true)
-        .args(&["target-path", "target-pid", "target-container", "no-target"]),
+        .args(&["target_path", "target_pid", "target_container", "no_target"]),
 ))]
 #[clap(group(
     ArgGroup::new("telemetry")
         .required(true)
-        .args(&["capture-path", "prometheus-addr", "prometheus-path"]),
+        .args(&["capture_path", "prometheus_addr", "prometheus_path"]),
 ))]
 #[clap(group(
      ArgGroup::new("experiment-duration")
            .required(false)
-           .args(&["experiment-duration-seconds", "experiment-duration-infinite"]),
+           .args(&["experiment_duration_seconds", "experiment_duration_infinite"]),
 ))]
 struct Opts {
     /// path on disk to the configuration file