De-duplicate block sizes #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottopell
force-pushed
the
sopell/dedup-block-sizes
branch
from
4bc9d01 to
f263ca1
Compare
blt
reviewed
Mar 5, 2024
| .iter() | ||
| .map(|sz| NonZeroU32::new(sz.get_bytes() as u32).expect("bytes must be non-zero")) | ||
| .collect(); | ||
| // TODO pass in datagram_friendly: true |
There was a problem hiding this comment.
intentional, this will be the next PR
blt
reviewed
Mar 5, 2024
Comment on lines
+750
to
+775
| #[must_use] | ||
| /// The default block sizes. | ||
| /// | ||
| /// Panics are not possible in practice due to these being static values. | ||
| /// # Panics | ||
| /// - Panics if a block size is not representable as a 32bit integer | ||
| /// - Panics if a block size is zero | ||
| pub fn default_blocks() -> Vec<NonZeroU32> { | ||
| [ | ||
| byte_unit::Byte::from_unit(1.0 / 32.0, byte_unit::ByteUnit::MB).expect("valid bytes"), | ||
| byte_unit::Byte::from_unit(1.0 / 16.0, byte_unit::ByteUnit::MB).expect("valid bytes"), | ||
| byte_unit::Byte::from_unit(1.0 / 4.0, byte_unit::ByteUnit::MB).expect("valid bytes"), | ||
| byte_unit::Byte::from_unit(1.0 / 2.0, byte_unit::ByteUnit::MB).expect("valid bytes"), | ||
| byte_unit::Byte::from_unit(1.0, byte_unit::ByteUnit::MB).expect("valid bytes"), | ||
| byte_unit::Byte::from_unit(2.0, byte_unit::ByteUnit::MB).expect("valid bytes"), | ||
| byte_unit::Byte::from_unit(4.0, byte_unit::ByteUnit::MB).expect("valid bytes"), | ||
| ] | ||
| .iter() | ||
| .map(|sz| { | ||
| NonZeroU32::new( | ||
| u32::try_from(sz.get_bytes()).expect("Block size not representable as 32bit integer"), | ||
| ) | ||
| .expect("Block size is non-zero") | ||
| }) | ||
| .collect() | ||
| } |
There was a problem hiding this comment.
This is so much nicer than having this copied everywhere.
blt
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the generators that take in
block_sizesas an argument and extracts that logic and default to a single location in the code.Motivation
Simplify my next set of changes and de-duplicate the code.
Related issues
Additional Notes