Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Proto bytes as attribute #216

Merged
merged 18 commits into from
Dec 15, 2023
Merged

Use Proto bytes as attribute #216

merged 18 commits into from
Dec 15, 2023

Conversation

dineshg13
Copy link
Member

@dineshg13 dineshg13 commented Dec 9, 2023 •
edited
Loading

What does this PR do?

Adds ability to send StatsPayload as bytes on provided channel.

Motivation

mx-psi
mx-psi reviewed Dec 12, 2023
View reviewed changes
.chloggen/dinesh.gurumurthy_OTEL-1305.yaml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
pkg/otlp/metrics/metrics_translator.go Outdated Show resolved Hide resolved
@mx-psi mx-psi added the breaking-change This PR introduces a Go API breaking change label Dec 12, 2023
@dineshg13 dineshg13 changed the title Use json encoded data Use Proto bytes as attribute Dec 12, 2023
dineshg13 and others added 2 commits December 12, 2023 13:03
@dineshg13 @mx-psi
Update .chloggen/dinesh.gurumurthy_OTEL-1305.yaml
1924541 
Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
@dineshg13
update gotidy
d82cd32
mx-psi
mx-psi reviewed Dec 13, 2023
View reviewed changes
pkg/otlp/metrics/sketches_test.go Outdated Show resolved Hide resolved
pkg/otlp/metrics/nan_metrics_test.go Outdated Show resolved Hide resolved
@mx-psi mx-psi removed the breaking-change This PR introduces a Go API breaking change label Dec 13, 2023
dineshg13 and others added 2 commits December 13, 2023 08:58
@dineshg13 dineshg13 marked this pull request as ready for review December 13, 2023 13:59
@dineshg13 dineshg13 requested a review from a team as a code owner December 13, 2023 13:59
@dineshg13 dineshg13 added the breaking-change This PR introduces a Go API breaking change label Dec 13, 2023
mx-psi
mx-psi reviewed Dec 13, 2023
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
pkg/otlp/metrics/metrics_translator.go Show resolved Hide resolved
pkg/otlp/metrics/metrics_translator.go Outdated Show resolved Hide resolved
pkg/otlp/metrics/metrics_translator.go Show resolved Hide resolved
@dineshg13 dineshg13 removed the breaking-change This PR introduces a Go API breaking change label Dec 14, 2023
@dineshg13 dineshg13 requested review from mx-psi and songy23 and removed request for liustanley December 14, 2023 19:11
songy23
songy23 approved these changes Dec 14, 2023
View reviewed changes
.chloggen/dinesh.gurumurthy_OTEL-1305.yaml Outdated Show resolved Hide resolved
pkg/otlp/metrics/statspayload_test.go Outdated Show resolved Hide resolved
pkg/otlp/metrics/statspayload_test.go Outdated Show resolved Hide resolved
dineshg13 and others added 2 commits December 15, 2023 09:54
@dineshg13 @songy23
Apply suggestions from code review
7e60e9c 
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
@dineshg13
Address PR feedback
8dd2c97
@dineshg13 @songy23
Update pkg/otlp/metrics/statspayload_test.go
ef7ecaf 
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
@dineshg13 dineshg13 merged commit 01206f4 into main Dec 15, 2023
7 checks passed
@dineshg13 dineshg13 deleted the dinesh.gurumurthy/OTEL-1305 branch December 15, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@mx-psi mx-psi mx-psi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dineshg13 @mx-psi @songy23