Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Puppet 4 and 5 support, add compatibility with Puppet stdlib 7 #803

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented Mar 19, 2024

What does this PR do?

Drops compatibility with Puppet 4 and 5, makes the module compatible with puppet stdlib 7.

Motivation

#800

Additional Notes

Describe your test plan

@bkabrda bkabrda requested review from a team as code owners March 19, 2024 08:13
@bkabrda bkabrda changed the title Slavek.kabrda/puppet 6 upgrade Drop Puppet 4 and 5 support, add compatibility with Puppet stdlib 7 Mar 19, 2024
Copy link

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with puppet, but the changes look reasonable to me - and if CI is green then approved 👍

Does this need a changelog entry or does that happen during the version bump/release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants