Skip to content

Commit

Permalink
Apply more PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
manuel-alvarez-alvarez committed Dec 13, 2024
1 parent 8635841 commit 78aa7bf
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions tests/appsec/test_automated_login_events.py
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ def test_login_sdk_failure_basic(self):
def setup_login_sdk_failure_local(self):
self.r_sdk_failure = weblog.post(
"/login?auth=local&sdk_event=failure&sdk_user=sdkUser&sdk_user_exists=true",
data=login_data(INVALID_USER, PASSWORD),
data=login_data(context, INVALID_USER, PASSWORD),
)

@missing_feature(weblog_variant="spring-boot-openliberty", reason="weblog returns error 500")
Expand Down Expand Up @@ -1226,9 +1226,9 @@ def validate_iden(meta):
self._assert_response(self.tests[2], validate_anon)


libs_without_user_id = {}
libs_without_user_exist = {}
libs_without_user_id_on_failure = {}
libs_without_user_id = []
libs_without_user_exist = []
libs_without_user_id_on_failure = []


@rfc("https://docs.google.com/document/d/1RT38U6dTTcB-8muiYV4-aVDCsT_XrliyakjtAPyjUpw")
Expand Down Expand Up @@ -1458,7 +1458,7 @@ def test_login_sdk_success_local(self):

# optional (to review for each library)
if context.library not in libs_without_user_id:
assert meta["usr.id"] == "social-security-id"
assert meta["usr.id"] == "sdkUser"
assert meta["_dd.appsec.usr.id"] == "social-security-id"

def setup_login_sdk_success_basic(self):
Expand All @@ -1482,7 +1482,7 @@ def test_login_sdk_success_basic(self):

# optional (to review for each library)
if context.library not in libs_without_user_id:
assert meta["usr.id"] == "social-security-id"
assert meta["usr.id"] == "sdkUser"
assert meta["_dd.appsec.usr.id"] == "social-security-id"

def setup_login_sdk_failure_local(self):
Expand Down

0 comments on commit 78aa7bf

Please sign in to comment.