fix irrelevent annotation

DataDog · Oct 25, 2024 · c85e1e8 · c85e1e8
1 parent 32ba8d5
commit c85e1e8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 19 deletions.
diff --git a/manifests/ruby.yml b/manifests/ruby.yml
@@ -267,7 +267,7 @@ tests/:
       test_kafka.py:
         Test_Kafka:
           "*": irrelevant
-          rails70: v0.1 # real version unknown
+          rails70: missing_feature (ruby-kafka integration does not set the kafka topic on spans)
       test_kinesis.py:
         Test_Kinesis_PROPAGATION_VIA_MESSAGE_ATTRIBUTES:
           "*": irrelevant
@@ -415,8 +415,12 @@ tests/:
     Test_Config_HttpClientErrorStatuses_FeatureFlagCustom: missing_feature
     Test_Config_HttpServerErrorStatuses_Default: v2.0.0
     Test_Config_HttpServerErrorStatuses_FeatureFlagCustom: missing_feature
-    Test_Config_IntegrationEnabled_False: v2.0.0
-    Test_Config_IntegrationEnabled_True: v2.0.0
+    Test_Config_IntegrationEnabled_False:
+      '*': irrelevant (endpoint not implemented)
+      rails70: v2.0.0
+    Test_Config_IntegrationEnabled_True:
+      '*': irrelevant (endpoint not implemented)
+      rails70: v2.0.0
     Test_Config_ObfuscationQueryStringRegexp_Configured: missing_feature
     Test_Config_ObfuscationQueryStringRegexp_Empty: missing_feature (enviornment variable is not supported)
     Test_Config_UnifiedServiceTagging_CustomService: v2.0.0

diff --git a/tests/test_config_consistency.py b/tests/test_config_consistency.py
@@ -323,14 +323,6 @@ def test_default_service_name(self):
 @rfc("https://docs.google.com/document/d/1kI-gTAKghfcwI7YzKhqRv2ExUstcHqADIWA4-TZ387o/edit#heading=h.8v16cioi7qxp")
 @scenarios.tracing_config_nondefault
 @features.tracing_configuration_consistency
-@irrelevant(
-    context.weblog_variant != "flask-poc" and context.library == "python",
-    reason="Avoids testing with weblog apps that do not implement the kafka/produce endpoint",
-)
-@irrelevant(
-    context.weblog_variant != "rails70" and context.library == "ruby",
-    reason="Avoids testing with weblog apps that do not implement the kafka/produce endpoint",
-)
 class Test_Config_IntegrationEnabled_False:
     """ Verify behavior of integrations automatic spans """
 
@@ -351,14 +343,6 @@ def test_kafka_integration_enabled_false(self):
 @rfc("https://docs.google.com/document/d/1kI-gTAKghfcwI7YzKhqRv2ExUstcHqADIWA4-TZ387o/edit#heading=h.8v16cioi7qxp")
 @scenarios.tracing_config_nondefault_2
 @features.tracing_configuration_consistency
-@irrelevant(
-    context.weblog_variant != "flask-poc" and context.library == "python",
-    reason="Avoids testing with weblog apps that do not implement the kafka/produce endpoint",
-)
-@irrelevant(
-    context.weblog_variant != "rails70" and context.library == "ruby",
-    reason="Avoids testing with weblog apps that do not implement the kafka/produce endpoint",
-)
 class Test_Config_IntegrationEnabled_True:
     """ Verify behavior of integrations automatic spans """