-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
general: update dd-trace-go to v2 (don't merge until v2 release) #1759
base: main
Are you sure you want to change the base?
Conversation
Don't merge until v2 is released. |
…ch's latest commit
This reverts commit d74dcf6.
Hi @darccio, do you still plan to work on this ? |
@cbeauchesne Yes, it's still work in progress. I was testing this right now because some Appsec RASP tests are failing. |
google.golang.org/grpc v1.57.1 | ||
google.golang.org/protobuf v1.30.0 | ||
gopkg.in/DataDog/dd-trace-go.v1 v1.39.0-alpha.1.0.20240419091955-7df262e804ad | ||
google.golang.org/grpc v1.64.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Library Vulnerability
google.golang.org/grpc → 1.64.0
Private tokens could appear in logs if context containing gRPC metadata is logged in github.com/grpc/grpc-go (...read more)
Impact
This issue represents a potential PII concern. If applications were printing or logging a context containing gRPC metadata, the affected versions will contain all the metadata, which may include private information.
Patches
The issue first appeared in 1.64.0 and is patched in 1.64.1 and 1.65.0
Workarounds
If using an affected version and upgrading is not possible, ensuring you do not log or print contexts will avoid the problem.
go4.org/intern v0.0.0-20230525184215-6c62f75575cb // indirect | ||
go4.org/unsafe/assume-no-moving-gc v0.0.0-20231121144256-b99613f794b6 // indirect | ||
golang.org/x/mod v0.14.0 // indirect | ||
golang.org/x/net v0.22.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Library Vulnerability
golang.org/x/net → 0.22.0
net/http, x/net/http2: close connections when receiving too many headers (...read more)
An attacker may cause an HTTP/2 endpoint to read arbitrary amounts of header data by sending an excessive number of CONTINUATION frames. Maintaining HPACK state requires parsing and processing all HEADERS and CONTINUATION frames on a connection. When a request's headers exceed MaxHeaderBytes, no memory is allocated to store the excess headers, but they are still parsed. This permits an attacker to cause an HTTP/2 endpoint to read arbitrary amounts of header data, all associated with a request which is going to be rejected. These headers can include Huffman-encoded data which is significantly more expensive for the receiver to decode than for an attacker to send. The fix sets a limit on the amount of excess header frames we will process before closing a connection.
…tion for trace ID in apmClientServer.OtelStartSpan
go4.org/intern v0.0.0-20230525184215-6c62f75575cb // indirect | ||
go4.org/unsafe/assume-no-moving-gc v0.0.0-20231121144256-b99613f794b6 // indirect | ||
golang.org/x/mod v0.14.0 // indirect | ||
golang.org/x/net v0.22.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Library Vulnerability
golang.org/x/net → 0.22.0
net/http, x/net/http2: close connections when receiving too many headers (...read more)
An attacker may cause an HTTP/2 endpoint to read arbitrary amounts of header data by sending an excessive number of CONTINUATION frames. Maintaining HPACK state requires parsing and processing all HEADERS and CONTINUATION frames on a connection. When a request's headers exceed MaxHeaderBytes, no memory is allocated to store the excess headers, but they are still parsed. This permits an attacker to cause an HTTP/2 endpoint to read arbitrary amounts of header data, all associated with a request which is going to be rejected. These headers can include Huffman-encoded data which is significantly more expensive for the receiver to decode than for an attacker to send. The fix sets a limit on the amount of excess header frames we will process before closing a connection.
Description
Motivation
Workflow
Once your PR is reviewed, you can merge it! ❤️
Reviewer checklist
run-parametric-scenario
,run-profiling-scenario
...). If this PR modifies any system-tests internal, then add therun-all-scenarios
label (more info).build-some-image
label is present