Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/build/docker/golang/app: update app for v2 API changes #1989

Merged
merged 8 commits into from
Jan 10, 2024

Conversation

knusbaum
Copy link
Contributor

@knusbaum knusbaum commented Jan 8, 2024

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@knusbaum knusbaum requested review from a team as code owners January 8, 2024 19:38
@robertomonteromiguel
Copy link
Collaborator

I guess We can change the status of this PR to Draft

@robertomonteromiguel robertomonteromiguel marked this pull request as draft January 9, 2024 07:13
@knusbaum knusbaum marked this pull request as ready for review January 9, 2024 21:02
@knusbaum knusbaum requested a review from a team January 10, 2024 13:53
@knusbaum knusbaum requested review from a team as code owners January 10, 2024 13:53
@knusbaum knusbaum requested review from juanjux, christophe-papazian, cataphract, DDJavierSantos, mcculls and nayeem-kamal and removed request for a team January 10, 2024 13:53
@darccio
Copy link
Member

darccio commented Jan 10, 2024

Oops, fixing.

@darccio
Copy link
Member

darccio commented Jan 10, 2024

@knusbaum I accidently merged main into this PR. I reverted that and recovered your changes, including the one from my suggestion. I'll do a quick review to make sure everything is fine.

@darccio darccio merged commit 469b577 into dario.castane/AIT-3705/dd-trace-go.v2 Jan 10, 2024
6 checks passed
@darccio darccio deleted the knusbaum/fix-for-2476 branch January 10, 2024 15:53
@darccio
Copy link
Member

darccio commented Jan 10, 2024

Thanks @knusbaum!

@cbeauchesne
Copy link
Collaborator

@darccio I'm a little bit worried to see a file impacting all parametric scenrio modified, and 5 parametric job failing on the last commit. Are you 100% sure it's not related?

@cbeauchesne
Copy link
Collaborator

So, my bad, you didn't merged it in main. I need some rest 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants