Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs] Enable Test_Blocking_request_body_multipart #3249

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

iunanua
Copy link
Contributor

@iunanua iunanua commented Oct 16, 2024

Motivation

With the multer instrumentation we can enable this test

Changes

Implement the multipart handler endpoint based on multer and enable Test_Blocking_request_body_multipart in manifest

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@iunanua iunanua marked this pull request as ready for review October 29, 2024 13:37
@iunanua iunanua requested review from a team as code owners October 29, 2024 13:37
Copy link
Member

@simon-id simon-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@iunanua
Copy link
Contributor Author

iunanua commented Oct 29, 2024

A test from DEBUGGER_LINE_PROBES_SNAPSHOT was failing.
But it's unrelated with this PR changes (i guess 😃)

That's why I merged main branch again...

@iunanua iunanua merged commit ee67d34 into main Oct 29, 2024
47 checks passed
@iunanua iunanua deleted the igor/nodejs-multipart-block branch October 29, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants