Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] semver format. fix a search and replace error #3318

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

avara1986
Copy link
Member

I had a mistake in my previous PR replacing v2.4.0.dev1 by v2.4.01

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@avara1986 avara1986 added the python Pull requests that update Python code label Oct 25, 2024
@avara1986 avara1986 marked this pull request as ready for review October 25, 2024 11:50
@avara1986 avara1986 requested review from a team as code owners October 25, 2024 11:50
@avara1986 avara1986 requested review from tabgok and romainkomorndatadog and removed request for a team October 25, 2024 11:50
@christophe-papazian christophe-papazian merged commit 9e4bdc1 into main Oct 25, 2024
39 of 47 checks passed
@christophe-papazian christophe-papazian deleted the avara1986/fix_s_r branch October 25, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants