Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating how to run binaries for Golang #3320

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Updating how to run binaries for Golang #3320

merged 4 commits into from
Oct 29, 2024

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Oct 25, 2024

Motivation

Cleaning up clutter and clarifying how to run golang binaries in the System-Tests repo.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mhlidd mhlidd requested a review from a team as a code owner October 25, 2024 12:40
@mhlidd mhlidd requested a review from mtoffl01 October 25, 2024 12:41
docs/execute/binaries.md Outdated Show resolved Hide resolved
@mhlidd mhlidd requested a review from mtoffl01 October 25, 2024 15:22
@mhlidd
Copy link
Contributor Author

mhlidd commented Oct 25, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 25, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@mhlidd
Copy link
Contributor Author

mhlidd commented Oct 25, 2024

/remove

@dd-devflow
Copy link

dd-devflow bot commented Oct 25, 2024

🚂 Devflow: /remove

@dd-devflow
Copy link

dd-devflow bot commented Oct 25, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

docs/execute/binaries.md Outdated Show resolved Hide resolved
Co-authored-by: Mikayla Toffler <46911781+mtoffl01@users.noreply.github.com>
@mhlidd mhlidd requested a review from mtoffl01 October 29, 2024 14:46
@mhlidd mhlidd merged commit 9709e9f into main Oct 29, 2024
456 of 459 checks passed
@mhlidd mhlidd deleted the mhlidd/fix_go_param_md branch October 29, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants