[golang] Migrate Parametric app from grpc to http #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Note: The 1 failing golang test is unrelated to these changes and should be fixed by this PR in dd-trace-go: DataDog/dd-trace-go#2960 |
ZStriker19
reviewed
Nov 1, 2024
| @@ -775,10 +775,8 @@ def test_tracestate_w3c_p_inject(self, test_agent, test_library): | |||
| with test_library: | |||
| with test_library.start_span(name="new_span") as span: | |||
| headers = test_library.inject_headers(span.span_id) | |||
|
|
|||
There was a problem hiding this comment.
Probably just revert changes to this file?
ZStriker19
reviewed
Nov 1, 2024
| @@ -162,9 +162,9 @@ def test_distinct_aggregationkeys_TS003(self, library_env, test_agent, test_libr | |||
|
|
|||
| if test_server.lang == "golang": | |||
| test_library.flush() | |||
|
|
|||
There was a problem hiding this comment.
Revert changes to this one too?
ZStriker19
reviewed
Nov 1, 2024
utils/parametric/headers.py
Outdated
| @@ -1,4 +1,6 @@ | |||
| def make_single_request_and_get_inject_headers(test_library, headers): | |||
| with test_library.start_span(name="name", service="service", resource="resource", http_headers=headers,) as span: | |||
| headers = test_library.inject_headers(span.span_id) | |||
| if not headers: # Check if headers is empty | |||
There was a problem hiding this comment.
Was this causing errors when the Go server didn't have any headers to inject? Rather than this, could the Go server just return an empty dictionary like other implementations?
ZStriker19
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
GRPC is hard to use; HTTP is easier to understand and maintain.
Changes
Migrates the web server used for golang parametric apps from grpc to net-http
Also, modifies the custom struct types used for decoding and manipulating json request data in the golang parametric app.
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present