Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parametric scenario output #3334

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

cbeauchesne
Copy link
Collaborator

Motivation

When container failed to start in parametric tests, the output is too verbose

Changes

  • remove debug and info logs from requests/urllib3 modules
  • remove warning from chained exception
  • print container logs in stdout

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@cbeauchesne cbeauchesne marked this pull request as ready for review October 29, 2024 13:22
@cbeauchesne cbeauchesne requested review from mabdinur and a team as code owners October 29, 2024 13:22
@cbeauchesne cbeauchesne merged commit e02dd69 into main Oct 29, 2024
455 of 461 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/improve-parametric-output branch October 29, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant