Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby test matrix [INPLAT-41] #3347

Merged
merged 20 commits into from
Nov 6, 2024

Conversation

emmettbutler
Copy link
Contributor

@emmettbutler emmettbutler commented Oct 30, 2024

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@emmettbutler emmettbutler requested a review from a team as a code owner October 30, 2024 16:10
@emmettbutler emmettbutler changed the title ruby test matrix ruby test matrix [INPLAT-41] Oct 30, 2024
@emmettbutler
Copy link
Contributor Author

This test currently fails when attempting to find the trace. We should probably skip it and then merge.

Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this error when we build the container:

#47 [ruby_3_1 3/10] RUN locale-gen en_US.UTF-8 #47 1.432 /bin/sh: locale-gen: not found #47 CANCELED failed to solve: process "/bin/sh -c locale-gen en_US.UTF-8" did not complete successfully: exit code: 127 ------ > [ruby_2_7 3/10] RUN locale-gen en_US.UTF-8: locale-gen: not found

Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good.
Only small change before merge it

@@ -0,0 +1,25 @@
weblog:
name: test-app-ruby-multialpine
exact_os_branches: [ubuntu24]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll set this by command line. We should remove this from here, because actually it should work on all vms

@@ -0,0 +1,25 @@
weblog:
name: test-app-ruby-multicontainer
exact_os_branches: [ubuntu24]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@emmettbutler emmettbutler merged commit 2a24480 into main Nov 6, 2024
461 of 464 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/ruby-matrix-libc.arch.runtime branch November 6, 2024 17:32
@emmettbutler emmettbutler restored the emmett.butler/ruby-matrix-libc.arch.runtime branch November 15, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants