-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruby test matrix [INPLAT-41] #3347
ruby test matrix [INPLAT-41] #3347
Conversation
This test currently fails when attempting to find the trace. We should probably skip it and then merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this error when we build the container:
#47 [ruby_3_1 3/10] RUN locale-gen en_US.UTF-8 #47 1.432 /bin/sh: locale-gen: not found #47 CANCELED failed to solve: process "/bin/sh -c locale-gen en_US.UTF-8" did not complete successfully: exit code: 127 ------ > [ruby_2_7 3/10] RUN locale-gen en_US.UTF-8: locale-gen: not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good.
Only small change before merge it
@@ -0,0 +1,25 @@ | |||
weblog: | |||
name: test-app-ruby-multialpine | |||
exact_os_branches: [ubuntu24] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll set this by command line. We should remove this from here, because actually it should work on all vms
@@ -0,0 +1,25 @@ | |||
weblog: | |||
name: test-app-ruby-multicontainer | |||
exact_os_branches: [ubuntu24] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present