Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Test_IastStandalone_UpstreamPropagation in nodejs #3376

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

iunanua
Copy link
Contributor

@iunanua iunanua commented Nov 5, 2024

Motivation

Test IAST vulnerability detection with standalone mode ON

Changes

  • Implement /vulnerablerequestdownstream
  • Add two new env var to the IAST_STANDALONE scenario for disabling vulnerability deduplication and enabling the IAST for all requests
    • DD_IAST_DEDUPLICATION_ENABLED=false
    • DD_IAST_REQUEST_SAMPLING=100

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@iunanua iunanua changed the title [nodejs] Enable Test_IastStandalone_UpstreamPropagation for node [nodejs] Enable Test_IastStandalone_UpstreamPropagation in nodejs Nov 5, 2024
@iunanua iunanua marked this pull request as ready for review November 5, 2024 15:00
@iunanua iunanua requested review from a team as code owners November 5, 2024 15:00
@iunanua iunanua changed the title [nodejs] Enable Test_IastStandalone_UpstreamPropagation in nodejs Enable Test_IastStandalone_UpstreamPropagation in nodejs Nov 5, 2024
@iunanua iunanua merged commit 7c013c0 into main Nov 6, 2024
462 of 467 checks passed
@iunanua iunanua deleted the igor/nodejs-standalone-billing-iast branch November 6, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants