Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Test_Agent from test_remote_configuration.py #3411

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

vpellan
Copy link
Contributor

@vpellan vpellan commented Nov 8, 2024

Motivation

This test was an easy win for Ruby but there was no manifest declaration. When talking about it with Charles, it was clarified that this test is testing nothing, except the /info endpoint but it should be rewritten somewhere else.

Changes

It removes Test_Agent from test_remote_configuration.py

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@vpellan vpellan requested review from a team as code owners November 8, 2024 09:30
@vpellan vpellan merged commit 40d4a82 into main Nov 8, 2024
292 checks passed
@vpellan vpellan deleted the vpellan/delete-remote-config-test-agent branch November 8, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants