Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Disable crash tracking test for all versions #3655

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

p-datadog
Copy link
Member

Motivation

Failing test when trying to release dd-trace-rb 2.8.0

Changes

This test was disabled for 2.7.2-dev and started failing again since we are releasing 2.8.0.

Make the disablement apply to all versions until the test is repaired.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

This test was disabled for 2.7.2-dev and started failing again
since we are releasing 2.8.0.

Make the disablement apply to all versions until the test is repaired.
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@cbeauchesne cbeauchesne changed the title Disable Ruby crash tracking test for all versions [ruby[ Disable crash tracking test for all versions Dec 10, 2024
@cbeauchesne cbeauchesne changed the title [ruby[ Disable crash tracking test for all versions [ruby] Disable crash tracking test for all versions Dec 10, 2024
p-datadog and others added 2 commits December 11, 2024 09:45
Co-authored-by: Charles de Beauchesne <charles.debeauchesne@datadoghq.com>
@p-datadog p-datadog merged commit e6c32ad into main Dec 11, 2024
77 checks passed
@p-datadog p-datadog deleted the disable-ruby-crash-tracking branch December 11, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants