Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert skipped obfuscator tests on PHP #597

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Revert skipped obfuscator tests on PHP #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions scenarios/appsec/test_traces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import pytest

from tests.constants import PYTHON_RELEASE_GA_1_1
from utils import BaseTestCase, context, interfaces, released, rfc, bug
from utils import BaseTestCase, context, interfaces, released, rfc

if context.library == "cpp":
pytestmark = pytest.mark.skip("not relevant")
Expand All @@ -17,7 +17,6 @@
class Test_AppSecObfuscator(BaseTestCase):
"""AppSec obfuscates sensitive data."""

@bug(context.php_appsec == "0.4.0")
def test_appsec_obfuscator_key(self):
"""General obfuscation test of several attacks on several rule addresses."""
# Validate that the AppSec events do not contain the following secret value.
Expand Down
2 changes: 0 additions & 2 deletions tests/appsec/test_traces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ def validator(span):
class Test_AppSecObfuscator(BaseTestCase):
"""AppSec obfuscates sensitive data."""

@bug(context.php_appsec == "0.4.0")
def test_appsec_obfuscator_key(self):
"""General obfuscation test of several attacks on several rule addresses."""
# Validate that the AppSec events do not contain the following secret value.
Expand Down Expand Up @@ -216,7 +215,6 @@ def validate_appsec_span_tags(span, appsec_data):
interfaces.library.add_appsec_validation(r, validate_appsec_span_tags)

@missing_feature(library="java")
@bug(context.php_appsec == "0.4.0")
def test_appsec_obfuscator_value(self):
"""Obfuscation test of a matching rule parameter value containing a sensitive keyword."""
# Validate that the AppSec event do not contain the following secret value.
Expand Down