Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PA-291] add aggregations option to metric_tag_configuration TF resource #1179

Merged
merged 14 commits into from
Oct 27, 2021

Conversation

efraese
Copy link
Contributor

@efraese efraese commented Aug 19, 2021

This PR adds support for a new aggregations field which can be used with count, rate, gauge metric tag configurations.

Updated go client here: https://github.com/DataDog/datadog-api-spec/pull/1126

Verified the following cases and used the GET /api/v2/{metric_name}/tags to verify attributes:

  • ✅ Create a new distribution, count, gauge tag configuration without aggregations and proper default is set
  • ✅ Update each type of tag configuration (change tags, toggle percentiles, update aggregations)
  • ✅ Ensure we cannot toggle percentiles for non-distribution metrics
  • ✅ Ensure we cannot add aggregations for distribution metrics
  • ✅ Import each type of tag configuration

@efraese efraese added the do-not-merge/WIP Do not merge this PR label Aug 19, 2021
@efraese efraese removed the do-not-merge/WIP Do not merge this PR label Oct 25, 2021
@efraese efraese marked this pull request as ready for review October 25, 2021 20:49
@efraese efraese requested review from a team as code owners October 25, 2021 20:49
chuck
chuck previously approved these changes Oct 25, 2021
Copy link
Contributor

@chuck chuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kayayarai
kayayarai previously approved these changes Oct 25, 2021
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny edit suggestion 👍

docs/resources/metric_tag_configuration.md Outdated Show resolved Hide resolved
@efraese efraese dismissed stale reviews from kayayarai and chuck via bfab454 October 26, 2021 11:49
@therve
Copy link
Contributor

therve commented Oct 27, 2021

/azp run

@therve therve enabled auto-merge (squash) October 27, 2021 12:44
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@therve therve merged commit 01db684 into master Oct 27, 2021
@therve therve deleted the eric.fraese/pa-291 branch October 27, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants