Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perpetual diff on some monitor JSON fields #1291

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

therve
Copy link
Contributor

@therve therve commented Nov 30, 2021

name and message are trimmed server side so we get a perpetual diff if
those fields start or end with spaces. This fixes it by tweaking the
state function.

Closes #1289

name and message are trimmed server side so we get a perpetual diff if
those fields start or end with spaces. This fixes it by tweaking the
state function.

Closes #1289
@therve therve requested review from a team as code owners November 30, 2021 13:15
@therve
Copy link
Contributor Author

therve commented Nov 30, 2021

/azp run

@therve therve enabled auto-merge (squash) November 30, 2021 14:20
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@therve therve merged commit 9148846 into master Nov 30, 2021
@therve therve deleted the therve/monitor-json-diff branch November 30, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle perpetual diff when monitor message starts or ends with spaces or cr
3 participants