[datadog_synthetics_test] Add support for grpc subtype #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cswatt
approved these changes
Jul 22, 2022
| @@ -446,6 +446,7 @@ Optional: | |||
| - `number_of_packets` (Number) Number of pings to use per test for ICMP tests (`subtype = "icmp"`) between 0 and 10. | |||
| - `port` (Number) Port to use when performing the test. | |||
| - `servername` (String) For SSL tests, it specifies on which server you want to initiate the TLS handshake, allowing the server to present one of multiple possible certificates on the same IP address and TCP port number. | |||
| - `service` (String) For gRPC tests, service to target for healthcheck. | |||
There was a problem hiding this comment.
Suggested change
| - `service` (String) For gRPC tests, service to target for healthcheck. | |
| - `service` (String) For gRPC tests, service to target for health check. |
There was a problem hiding this comment.
I purposefully put healthcheck to match what we have in the UI. If we're to change that's a discussion I need to have with my PMs.
Thank you very much for the review! I will bring the question to my Product team!
| @@ -732,6 +733,7 @@ Optional: | |||
| - `number_of_packets` (Number) Number of pings to use per test for ICMP tests (`subtype = "icmp"`) between 0 and 10. | |||
| - `port` (Number) Port to use when performing the test. | |||
| - `servername` (String) For SSL tests, it specifies on which server you want to initiate the TLS handshake, allowing the server to present one of multiple possible certificates on the same IP address and TCP port number. | |||
| - `service` (String) For gRPC tests, service to target for healthcheck. | |||
There was a problem hiding this comment.
Suggested change
| - `service` (String) For gRPC tests, service to target for healthcheck. | |
| - `service` (String) For gRPC tests, service to target for health check. |
therve
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.