Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize TestDatadogDashListImport test by always creating resources in the same order #442

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Stabilize TestDatadogDashListImport test by always creating resources in the same order #442

merged 1 commit into from
Mar 11, 2020

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented Mar 11, 2020

Previously, the test would fail in ~50 % of runs, as the screen and time dashboards were created in random order.

@ghost ghost added the size/XS label Mar 11, 2020
jirikuncar
jirikuncar approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@jirikuncar jirikuncar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@bkabrda
Copy link
Contributor Author

bkabrda commented Mar 11, 2020

Thanks for the review, merging.

@bkabrda bkabrda merged commit 1e90d4c into DataDog:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirikuncar jirikuncar jirikuncar approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkabrda @jirikuncar