-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to kubebuilder multigroup support #207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies
clamoriniere
force-pushed
the
clamoriniere/multi-group-support
branch
from
March 21, 2024 21:21
528ad29
to
f36db2e
Compare
clamoriniere
force-pushed
the
clamoriniere/multi-group-support
branch
from
March 21, 2024 21:34
f36db2e
to
774af84
Compare
clamoriniere
force-pushed
the
clamoriniere/multi-group-support
branch
from
March 21, 2024 21:43
774af84
to
80ccc39
Compare
clamoriniere
force-pushed
the
clamoriniere/multi-group-support
branch
from
April 23, 2024 08:19
80ccc39
to
ff57265
Compare
clamoriniere
force-pushed
the
clamoriniere/multi-group-support
branch
from
May 31, 2024 12:25
ff57265
to
0ae0bf2
Compare
clamoriniere
force-pushed
the
clamoriniere/multi-group-support
branch
from
June 18, 2024 19:02
0ae0bf2
to
fc074c5
Compare
clamoriniere
force-pushed
the
clamoriniere/multi-group-support
branch
from
July 4, 2024 12:42
fc074c5
to
da65c9d
Compare
vboulineau
previously approved these changes
Jul 4, 2024
for now we can't move to 1.22 due to a controler-gen panic issue, see: kubernetes-sigs/controller-tools#880
clamoriniere
dismissed stale reviews from vboulineau and github-actions[bot]
via
July 4, 2024 15:45
d349160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For futur development we need to migrate the project to kubebuilder multigroup support
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.