recommender: fix instrumentation and add tests #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
vboulineau
reviewed
Nov 7, 2024
| @@ -29,7 +29,10 @@ const ( | |||
| transitionPromLabel = "transition" | |||
| lifecycleStatus = "lifecycle_status" | |||
| monitorName = "monitor_name" | |||
| monitorNamespace = "monotor_namespace" | |||
| monitorNamespace = "monitor_namespace" | |||
| clientPromLabel = "client" | |||
There was a problem hiding this comment.
The recommender or target/target_url name was perhaps more meaningful. As it's a not generic HTTP Client but only dedicated to call recommenders.
There was a problem hiding this comment.
sure, but these metrics could be used for any http call (now that they are in "metrics") - and client contains the url of the recommender when it's a recommender
There was a problem hiding this comment.
Fair point, the metrics should be more specific then I think, but LGTM
vboulineau
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix recommender metrics ("recommender" != "client")