Use ungeneralized types for flexible schema and planner #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroecheler
requested changes
Oct 12, 2023
|
|
||
| String getName(); | ||
| //First entry is the preferred name, the remaining are for backwards compatibility | ||
| List<String> getName(); |
There was a problem hiding this comment.
IMHO a better approach would be to have two methods:
//Name of the type
default String getName() { getNames().get(0); }
//List of names for this type (for backwards compatibility)
List<String> getNames()
Otherwise you are leaking interface specifics (i.e. that the first name in the list is the default name) to the outside and pushing the responsibility onto the user to enforce it (as you can see by the various calls in AbstractBasicType to getName().get(0))
Also, a method that returns a collection should have a plural name.
There was a problem hiding this comment.
Good point, got too hung up on the generic issues and forgot about interface
| * type definition syntax. | ||
| */ | ||
| @SneakyThrows | ||
| public static RelDataType parseDatatype(String datatype) { |
There was a problem hiding this comment.
Should this go into CalciteUtil?
There was a problem hiding this comment.
I'll actually tie it closer to the planner since it can be pretty expensive to run and the planner can hold the state we would need
mbroecheler
approved these changes
Oct 12, 2023
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
henneberger
added a commit
that referenced
this pull request
Oct 13, 2023
* Use ungeneralized types for flexible schema and planner Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Fix generics Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Update other file Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Minor code changes Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Fix equality Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
henneberger
added a commit
that referenced
this pull request
Oct 13, 2023
* Use ungeneralized types for flexible schema and planner Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Fix generics Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Update other file Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Minor code changes Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Fix equality Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves away from the generalized graphql-esque type mapping to the more concrete sql types.
Some schemas are published in the registry so the flexible schema is made to be backwards compatible.
Also removes UUID type.