Update library to use bridging flink functions #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henneberger
changed the title
henneberger
changed the title
mbroecheler
approved these changes
Oct 12, 2023
| Optional<SqlFunction> function = FunctionUtil.getFunctionByNameFromClass(FlinkSqlOperatorTable.class, originalName); | ||
| Preconditions.checkArgument(function.isPresent()); | ||
| return new CalciteFunctionNsObject(Name.system(name), function.get(), originalName); | ||
| FlinkConverter converter = new FlinkConverter(new RexBuilder(TypeFactory.getTypeFactory()), |
There was a problem hiding this comment.
Is it not going to be a problem that we create new type factories here? And why create two instances?
There was a problem hiding this comment.
Fixed dependencies.
henneberger
changed the title
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
henneberger
added a commit
that referenced
this pull request
Oct 13, 2023
* Use ungeneralized types for flexible schema and planner Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Update other file Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Update library to use briding flink functions Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
henneberger
added a commit
that referenced
this pull request
Oct 13, 2023
* Use ungeneralized types for flexible schema and planner Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Update other file Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Update library to use briding flink functions Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.