-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support table functions in SQL #391
Conversation
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome - thanks for getting this to work. It really highlights our contributions to SQL by being able to reuse those functions. Well done!
One minor nit.
@@ -107,6 +109,9 @@ public void addRelationship(Relationship relationship) { | |||
this.sysTableToRelationshipMap.put(relationship.getFromTable(), relationship); | |||
plus().add(String.join(".", relationship.getPath().toStringList()) + "$" | |||
+ sqrlFramework.getUniqueMacroInt().incrementAndGet(), relationship); | |||
if (!relationship.getParameters().isEmpty()) { | |||
plus().add(String.join(".", relationship.getPath().toStringList()), relationship); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should call a helper function. We should already have one for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in next commit
Initial support for table functions in SQL. Supports calling sqrl table functions but does not impart sqrl native table paths.