Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator consolidation #467

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Validator consolidation #467

merged 2 commits into from
Jan 9, 2024

Conversation

henneberger
Copy link
Contributor

@henneberger henneberger commented Dec 17, 2023

Separation of validator with planner was too cumbersome and didn't produce any tangible benefit.

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (deb6cbe) 52.45% compared to head (6179889) 52.28%.

Files Patch % Lines
...java/com/datasqrl/plan/validate/ScriptPlanner.java 88.88% 7 Missing and 3 partials ⚠️
...src/main/java/com/datasqrl/plan/ScriptPlanner.java 58.82% 4 Missing and 3 partials ⚠️
...c/main/java/com/datasqrl/calcite/QueryPlanner.java 0.00% 2 Missing ⚠️
.../src/main/java/com/datasqrl/calcite/SqrlToSql.java 92.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #467      +/-   ##
============================================
- Coverage     52.45%   52.28%   -0.17%     
- Complexity     1172     1173       +1     
============================================
  Files           585      583       -2     
  Lines         17279    17122     -157     
  Branches       2097     2079      -18     
============================================
- Hits           9064     8953     -111     
+ Misses         7154     7120      -34     
+ Partials       1061     1049      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henneberger henneberger marked this pull request as draft December 17, 2023 17:42
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
@henneberger henneberger marked this pull request as ready for review January 9, 2024 23:32
@henneberger henneberger merged commit b685f69 into main Jan 9, 2024
3 checks passed
@henneberger henneberger deleted the validator branch January 9, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant