Add support to import from and export to the log engine #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandorsoma
force-pushed
the
731-importexport-logs
branch
from
11b7134 to
c591b4d
Compare
henneberger
force-pushed
the
731-importexport-logs
branch
2 times, most recently
from
c0f183a to
d719afc
Compare
henneberger
reviewed
Aug 29, 2024
| throw addError(ErrorCode.GENERIC, node, "Could not find module [%s] at path: [%s]", | ||
| path, String.join("/", path.toStringList())); | ||
| } | ||
| if (path.getFirst().getDisplay().equals("log")) { |
There was a problem hiding this comment.
we can move this into the module loader as a custom module
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
henneberger
force-pushed
the
731-importexport-logs
branch
from
50b905d to
52c371b
Compare
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#731