-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add udf support to run/test #851
Conversation
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment on the test
@@ -0,0 +1,2 @@ | |||
>>>MyTable.graphql | |||
{"data":{"MyTable":[{"val":1},{"val":2},{"val":3},{"val":4},{"val":5},{"val":6},{"val":7},{"val":8},{"val":9},{"val":10}]}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If MyScalarFunction adds the two arguments, shouldn't those values be double what they are?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you are only returning "val". Can you add myFunc instead so we can test that the function actually gets invoked?
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
No description provided.