Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add udf support to run/test #851

Merged
merged 5 commits into from
Oct 6, 2024
Merged

Add udf support to run/test #851

merged 5 commits into from
Oct 6, 2024

Conversation

henneberger
Copy link
Contributor

No description provided.

@henneberger henneberger changed the base branch from main to moretests October 2, 2024 18:45
Base automatically changed from moretests to main October 2, 2024 19:20
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
@henneberger henneberger marked this pull request as ready for review October 2, 2024 19:22
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Copy link
Contributor

@mbroecheler mbroecheler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment on the test

@@ -0,0 +1,2 @@
>>>MyTable.graphql
{"data":{"MyTable":[{"val":1},{"val":2},{"val":3},{"val":4},{"val":5},{"val":6},{"val":7},{"val":8},{"val":9},{"val":10}]}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If MyScalarFunction adds the two arguments, shouldn't those values be double what they are?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you are only returning "val". Can you add myFunc instead so we can test that the function actually gets invoked?

Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
@henneberger henneberger merged commit 011802a into main Oct 6, 2024
1 check passed
@henneberger henneberger deleted the udfs branch October 6, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants