Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/DP-235 assign roles on account creation #4

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Feat/DP-235 assign roles on account creation #4

merged 2 commits into from
Sep 17, 2024

Conversation

lautaro79
Copy link
Collaborator

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

juanmzaragoza
juanmzaragoza approved these changes Sep 17, 2024
View reviewed changes
Copy link

@juanmzaragoza juanmzaragoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest removing the .env file from the repository

@lautaro79
Copy link
Collaborator Author

lautaro79 commented Sep 17, 2024 •
edited
Loading

I would suggest removing the .env file from the repository

Thanks for the suggestion.

I don't think that is a choice, that file is from the original Superset repo and it has some needed configurations

@lautaro79 lautaro79 merged commit 145eee1 into master Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanmzaragoza juanmzaragoza juanmzaragoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lautaro79 @juanmzaragoza